initial feedback -- DO NOT MERGE#19
Open
dpcairns wants to merge 1 commit intoUniKittyCorns:mainfrom
dpcairns:main
Open
initial feedback -- DO NOT MERGE#19dpcairns wants to merge 1 commit intoUniKittyCorns:mainfrom dpcairns:main
dpcairns wants to merge 1 commit intoUniKittyCorns:mainfrom
dpcairns:main
Conversation
Author
|
This codebase is so clean that I don't have a lot to add! Great work managing the complexity of a grid of data with only foundations i skills--it's no easy task, and you pulled it off in a way that's readable and functional! |
Author
|
Presentation feedback: Great product talk—concise telling of all the features available in your app with a crowd pleasing ‘reveal’! The tech talk has a great walk-through of your very readable code, and the readable and modular functions made it really smooth fun for the audience to watch. Your walkthrough of how you made the decision of which score to render on the high score page was especially engaging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.