refactor(netpacket): Simplify raw byte data handling in NetPacket:FillBuffer functions

[xezon]

• Follow up for refactor(netpacket): Simplify initialization of net packet field types #2288

This change simplifies raw byte data handling in NetPacket:FillBuffer functions.

[greptile-apps]

Greptile Summary

Refactored multiple FillBuffer functions to use pointer arithmetic (buffer += sizeof(...)) instead of offset-based indexing (buffer + offset), improving code clarity and reducing opportunities for offset calculation errors.

Key changes:

• ConstructNetCommandMsgFromRawData: Uses sizeof(variable) instead of hardcoded type sizes for consistency
• FillBufferWithGameCommand: Replaced offset arithmetic with direct buffer pointer advancement
• FillBufferWithDisconnectChatCommand: Removed manual offset tracking
• FillBufferWithChatCommand: Simplified variable data writing with pointer arithmetic
• FillBufferWithFileMessage: Replaced character-by-character filename copying with single memcpy using getByteCount() + 1
• FillBufferWithFileAnnounceMessage: Same filename handling improvement

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The refactoring systematically replaces offset-based buffer indexing with pointer arithmetic throughout multiple functions. The changes are mechanical and improve code safety by eliminating manual offset tracking. Previous thread comments have been addressed (the commandTypeByte conversion is now correctly implemented). All changes follow the same pattern and are functionally equivalent to the original code.
• No files require special attention

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameNetwork/NetPacket.cpp	Refactored buffer writing to use pointer arithmetic instead of offset calculations, improving code clarity and safety

Flowchart

flowchart TD
    A[Start: FillBuffer function called] --> B[Create packet struct]
    B --> C[Copy fixed packet header to buffer]
    C --> D[Advance buffer pointer: buffer += sizeof]
    D --> E{Variable data to write?}
    E -->|Yes| F[Write data to buffer]
    F --> G[Advance buffer pointer]
    G --> E
    E -->|No| H[End: Buffer filled]
    
    style D fill:#90EE90
    style G fill:#90EE90
    style C fill:#87CEEB
    style F fill:#87CEEB

Loading

_{Last reviewed commit: 4f21260}

[greptile-apps]

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}