Add assuring that exported is a string#43
Open
zhakhalov wants to merge 1 commit intoTheLarkInn:masterfrom
Open
Add assuring that exported is a string#43zhakhalov wants to merge 1 commit intoTheLarkInn:masterfrom
zhakhalov wants to merge 1 commit intoTheLarkInn:masterfrom
Conversation
|
@zhakhalov This would work very well for my case. I am using style-loader to pull the generated css in outside of the component (so I can do hot reload) and had to work around the fact that what ends up in styles is not a string. Would love it if this was done automatically. |
Author
|
Hey @TheLarkInn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have met issue caused by using of ExtractTextPlugin with following error message:
Idea of my fix is an ensuring that each element of
styleUrlsis a string.The result (in bundle) looks like:
I would not like to update tests untill your approval of solution.
Waiting for your response.
Thanks in advance.