Adding type assertion <string> option to fix issues with typescript type checks#37
Open
julianosam wants to merge 4 commits intoTheLarkInn:masterfrom
Open
Adding type assertion <string> option to fix issues with typescript type checks#37julianosam wants to merge 4 commits intoTheLarkInn:masterfrom
julianosam wants to merge 4 commits intoTheLarkInn:masterfrom
Conversation
Current coverage is 95.65% (diff: 100%)@@ master #37 diff @@
==========================================
Files 1 1
Lines 17 23 +6
Methods 5 5
Messages 0 0
Branches 3 6 +3
==========================================
+ Hits 16 22 +6
Misses 1 1
Partials 0 0
|
3 similar comments
Current coverage is 95.65% (diff: 100%)@@ master #37 diff @@
==========================================
Files 1 1
Lines 17 23 +6
Methods 5 5
Messages 0 0
Branches 3 6 +3
==========================================
+ Hits 16 22 +6
Misses 1 1
Partials 0 0
|
Current coverage is 95.65% (diff: 100%)@@ master #37 diff @@
==========================================
Files 1 1
Lines 17 23 +6
Methods 5 5
Messages 0 0
Branches 3 6 +3
==========================================
+ Hits 16 22 +6
Misses 1 1
Partials 0 0
|
Current coverage is 95.65% (diff: 100%)@@ master #37 diff @@
==========================================
Files 1 1
Lines 17 23 +6
Methods 5 5
Messages 0 0
Branches 3 6 +3
==========================================
+ Hits 16 22 +6
Misses 1 1
Partials 0 0
|
Owner
|
Would you merge conflicts sorry I'm just getting to this. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript complains about the return type of the require() function once A2 defines the component template field as type string. The correct A2 component annotation should be as follows:
This adds an option to include
typeAssertionto the require() generation. It supports both passing it as a query paramangular2-template-loader?typeAssertion=trueor the via options plugin supported by Webpack 2. Right now, it leaves the type assertion inclusion defaulted tofalse. But I think it should be defaulted totruein a near future.