designs: ihp-sg13g2: i2c-gpio-expander: Fix padring power/ground nets #3874
+8
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove add_global_connections for padring cells in the PDN_TCL file. These nets should be defined in the FOOTPRINT_TCL before the padring is created. Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
…_connection Add global connections for the padring before the padring actually got created. So, move the add_global_connections from the pdn.tcl file to the pad.tcl file. Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
Member
|
Why move the pad related connect out of the platform? It seems like it would be relevant to any design with pads, no? |
Contributor
Author
The I would like to make a proposal soon to move some of common code from https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/blob/master/flow/designs/ihp-sg13g2/i2c-gpio-expander/pad.tcl into a platform-specific file. For example, the |
Contributor
Author
|
I wrote down my idea here: #3875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place
add_global_connectionfor power and ground nets in the padring before the padring got created.Also remove
add_global_connectionfrom the ihp-sg13g2 defaultpdn.tclfile, because it should be defined in theFOOTPRINT_TCLfile.See #3867 for reference.