Change image to scratch & builder image to alpine#193
Open
peterzam wants to merge 2 commits intoTeamPiped:mainfrom
Open
Change image to scratch & builder image to alpine#193peterzam wants to merge 2 commits intoTeamPiped:mainfrom
peterzam wants to merge 2 commits intoTeamPiped:mainfrom
Conversation
Bnyro
requested changes
Aug 10, 2024
| RUN apk add --no-cache nasm git g++ | ||
|
|
||
| COPY . . | ||
| RUN git clone https://github.com/TeamPiped/piped-proxy.git /app |
Member
There was a problem hiding this comment.
That's unnecessary, you should just leave that as it was before and copy the source code from the current directory instead of cloning it.
vlnst
reviewed
May 31, 2025
| RUN --mount=type=cache,target=/var/cache/apt \ | ||
| apt-get update && \ | ||
| apt-get install -y --no-install-recommends \ | ||
| ca-certificates && \ |
There was a problem hiding this comment.
You need ca-certificates in image, otherwise HTTPS won't work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make smaller image size