using spike_vector on core/check_sortings_equal test
#4282
+28
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
alejoe91
reviewed
Dec 23, 2025
Member
|
@tayheau I think we actually needed the unit_index lex sort after all! The reason is that before we were testing spiketrain-by-spiketrain, so the order didn't matter if we had synchronous spikes. Now with the spike vector representation we need to ensure unit_index is sorted too! Sorry about that! :) |
for more information, see https://pre-commit.ci
alejoe91
reviewed
Jan 22, 2026
alejoe91
reviewed
Jan 22, 2026
alejoe91
approved these changes
Jan 22, 2026
…spike_vector_test_check_sorting_equal
…yheau/spikeinterface into spike_vector_test_check_sorting_equal
alejoe91
reviewed
Jan 22, 2026
| spikes.append(spikes_in_seg) | ||
|
|
||
| spikes = np.concatenate(spikes) | ||
| spikes = spikes[np.lexsort((spikes["unit_index"], spikes["sample_index"], spikes["segment_index"]))] |
Member
There was a problem hiding this comment.
@samuelgarcia I think it's better to lexsort the whole array at the end to make sure that units are also sorted within samples
alejoe91
reviewed
Jan 22, 2026
|
|
||
| spikes = np.concatenate(spikes) | ||
| spikes = spikes[np.lexsort((spikes["sample_index"], spikes["segment_index"]))] | ||
| spikes = spikes[np.lexsort((spikes["unit_index"], spikes["sample_index"], spikes["segment_index"]))] |
Member
There was a problem hiding this comment.
we were missing the unit index lexsort in generate
alejoe91
reviewed
Jan 22, 2026
Comment on lines
+298
to
+299
| spikes = spikes[np.lexsort((spikes["unit_index"], spikes["sample_index"], spikes["segment_index"]))] | ||
| self._cached_spike_vector = spikes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this todo