fix(Expo): fix Android bundle loader reflection#118
Merged
Conversation
…g CodePush release
floydkim
force-pushed
the
add-expo-example-apps
branch
from
ddb2e93 to
36f7c1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We previously had an OTA update bundle loading failure in Expo environments, and addressed it in commit 96daa89.
This PR adds Expo example apps so that fix can be reproduced and validated consistently.
Related fix in commit 96daa89
In
android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java,setJSBundleLoaderBridgelessnow resolves the bundle loader field with Expo compatibility:jsBundleLoader_jsBundleLoaderfirst, then falls back tojsBundleLoaderThis prevents OTA apply failures when Expo’s ReactHost delegate exposes the loader via
_jsBundleLoader.What this PR adds
Examples/Expo54Examples/Expo55Beta