Skip to content

Decouple test reporter IO from test execution #3962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrocha merged 1 commit into from
Feb 19, 2026
Merged

Decouple test reporter IO from test execution #3962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/ruby_lsp/test_reporters/lsp_reporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ def initialize
end #: IO | StringIO

@invoked_shutdown = false #: bool
@message_queue = Thread::Queue.new #: Thread::Queue
@writer = Thread.new { write_loop } #: Thread
end

#: -> void
Expand All @@ -95,6 +97,8 @@ def internal_shutdown
@invoked_shutdown = true

send_message("finish")
@message_queue.close
@writer.join
@io.close
end

Expand Down Expand Up @@ -227,7 +231,14 @@ def socket(port)
#: (String?, **untyped) -> void
def send_message(method_name, **params)
json_message = { method: method_name, params: params }.to_json
@io.write("Content-Length: #{json_message.bytesize}\r\n\r\n#{json_message}")
@message_queue << "Content-Length: #{json_message.bytesize}\r\n\r\n#{json_message}"
end

#: -> void
def write_loop
while (message = @message_queue.pop)
@io.write(message)
end
end
end
end
Expand Down
Loading