Merged
Conversation
Member
Author
|
!result! 🕺 🍾 🥳 One day we'll be adopting Ruff, which may or not make this easier. Meanwhile, we still have failiing tests here, due to need for #197 (xarray breakage) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt + apply new isort settings.
Since we were getting repeated problems where the isort in CI on PRs disagreed with the local pre-commit fixes.
It seems this was due to confusion over what is a "firstparty" module, depdending (presumably) on the current directory when run. Also similar problems recognising that "tests" is a local module.
Hopefully this resolves all that, and will not receive a pre-commit update on this PR.