Performance improvements to ValueHelper#31
Merged
guille-sage merged 3 commits intomasterfrom Feb 16, 2026
Merged
Conversation
- Put more common types higher up the if-else clause
- Use a constant regex instead of creating a new one on every call
- Use RegExp#match? instead of `===` (no MatchData allocation)
- Avoid calling .to_s.downcase repeatedly:
- Extract into single `#to_s` call
- Let regex match in case-insensitive mode
guille-sage
force-pushed
the
performance-1
branch
from
35f1d9b to
4baeed1
Compare
PawelKlapec
approved these changes
Feb 16, 2026
mob1970
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
===(no MatchData allocation)#to_scallBased on the new extended benchmarks (#30), it doesn't make much of an impact. Minor improvement, though.