Skip to content

tests: reorganize infopipe tests by interface#8451

Open
aborah-sudo wants to merge 1 commit intoSSSD:masterfrom
aborah-sudo:rearrange
Open

tests: reorganize infopipe tests by interface#8451
aborah-sudo wants to merge 1 commit intoSSSD:masterfrom
aborah-sudo:rearrange

Conversation

@aborah-sudo
Copy link
Contributor

Group the infopipe tests into logical sections based on the D-Bus interface they exercise:

  • Infopipe (root object)
  • Domains
  • Users
  • Groups
  • Mixed/Combined interfaces

This is a pure reorganization with no logic changes to improve test maintainability and readability.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively reorganizes the infopipe tests into logical sections based on the D-Bus interface, which significantly improves test maintainability and readability as intended. The addition of new tests is also a great enhancement. I have one suggestion to improve the robustness of one of the new tests.

@aborah-sudo aborah-sudo changed the title test: reorganize infopipe tests by interface tests: reorganize infopipe tests by interface Feb 16, 2026
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Group the infopipe tests into logical sections based on the D-Bus
interface they exercise:
- Infopipe (root object)
- Domains
- Users
- Groups
- Mixed/Combined interfaces

This is a pure reorganization with no logic changes to improve test
maintainability and readability.

Reviewed-by: Jakub Vávra <jvavra@redhat.com>
@sssd-bot
Copy link
Contributor

The pull request was accepted by @aborah-sudo with the following PR CI status:


🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
➖ ci / intgcheck (skipped)
🔴 ci / prepare (failure)
➖ ci / system (skipped)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants