UTIL: diff_string_lists() optimization#8450
Draft
alexey-tikhonov wants to merge 1 commit intoSSSD:masterfrom
Draft
UTIL: diff_string_lists() optimization#8450alexey-tikhonov wants to merge 1 commit intoSSSD:masterfrom
diff_string_lists() optimization#8450alexey-tikhonov wants to merge 1 commit intoSSSD:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant optimization to the diff_string_lists function. The changes effectively reduce memory allocations by avoiding talloc_strdup when building the initial hash table and by pre-allocating the result arrays instead of using talloc_realloc inside loops.
However, I've found a critical issue where the return value of talloc_realloc is not checked when shrinking the result arrays. This can lead to silent failures on memory allocation errors, where the function would return EOK but with a NULL list, potentially causing NULL pointer dereferences in calling code. I've added comments with suggestions to fix this.
- don't copy string to use as keys - don't realloc inside a loop - don't use `hash_keys()` to avoid data copy
alexey-tikhonov
force-pushed
the
initgr-loops
branch
from
0c52ab6 to
61ba5a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.