Rename Makefile.am to Makefile.am.#8375
Open
mervdowapple1-prog wants to merge 1 commit intoSSSD:masterfrom
Open
Rename Makefile.am to Makefile.am.#8375mervdowapple1-prog wants to merge 1 commit intoSSSD:masterfrom
mervdowapple1-prog wants to merge 1 commit intoSSSD:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request renames Makefile.am to Makefile.am.. This change appears to be a mistake and will likely break the build process. The GNU Automake toolchain, which this project appears to use, specifically looks for a file named Makefile.am by default to generate the Makefile.in. Renaming it to Makefile.am. will cause automake to fail, as it won't find its input file. This is a critical issue that will prevent the project from being built. I recommend reverting this change.
Member
|
@mervdowapple1-prog, what's the point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.