[autobackport: sssd-2-10] adding enumeration system tests #8345
Open
sssd-bot wants to merge 2 commits intoSSSD:sssd-2-10from
Open
[autobackport: sssd-2-10] adding enumeration system tests #8345sssd-bot wants to merge 2 commits intoSSSD:sssd-2-10from
sssd-bot wants to merge 2 commits intoSSSD:sssd-2-10from
Conversation
added 2 commits
January 9, 2026 19:52
There was a problem hiding this comment.
Code Review
This pull request is an automatic backport that replaces old integration tests for enumeration with new system tests. This is achieved by parameterizing several existing system tests in test_nss.py to run with enumeration enabled. The changes are logical and improve test coverage for the enumeration feature.
I have one suggestion to improve the maintainability of the newly added test logic by refactoring duplicated code into a pytest fixture. This would make the test suite cleaner and easier to maintain in the long run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8280 adding enumeration system tests to branch sssd-2-10, created by @danlavu.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
160bbb3 - adding parametrized enumeration enabled tests
5b5dce2 - removing intg enumeration tests.
Backported commits
Original Pull Request Body