Merged
Conversation
KOLANICH
force-pushed
the
efficiency_1
branch
from
a054212 to
b98eabb
Compare
Owner
|
Hello @KOLANICH thank you very much for splitting your changes! This one is very good indeed: I was actually starting to work on a similar refactor this morning when I was remembered of it. After this get in, please don't hesitate to rebase/retarget your other pull request so that we can have some more in. Basically I am only looking at a PR seriously when it passes all checks (which can lead to some wasted like this one). Cheers! |
Contributor
Author
|
Thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitted #241 even further. Should be a bit more reviewable what I have done than when collapsed into a single commit. Though it is not yet fully usable, let's try to troubleshhot step-by-step.