Open
Conversation
- Added initial isValid(timeout) check which will return true if the
client can send a request to the server and receive a reply within
the timeout
- timeout is given in seconds
- Updated Connection.send so that it can accept a communicationTimeout
option to timeout a request to the server and return a timeout error
- Added unit and integration tests for isValid
- Added the connect option communicationTimeout which indicates in
milliseconds how long the client will wait for a response to individual
packet requests before timing out and producing an error
- The connect option will affect all packet requests to the server
including packets sent when connecting, fetches, write lobs,
commits and rollbacks
- Note that although the client may timeout, the packet can still
reach the server, i.e. commit packets can commit on the server
despite a timeout on the client side
- Added the communicationTimeout to the options field of Client.exec,
Client.execute, Client.prepare, Statement.exec and Statement.execute
- Will timeout packet requests associated with the function
after the given milliseconds
- Updated the unit and integration tests to test and include the
communicationTimeout option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
milliseconds how long the client will wait for a response to individual
packet requests before timing out and producing an error
including packets sent when connecting, fetches, write lobs,
commits and rollbacks
reach the server, i.e. commit packets can commit on the server
despite a timeout on the client side
Client.execute, Client.prepare, Statement.exec and Statement.execute
after the given milliseconds
communicationTimeout option