Fixed LOB stream multiple callback and deadlock#266
Open
he-is-harry wants to merge 2 commits intoSAP:masterfrom
Open
Fixed LOB stream multiple callback and deadlock#266he-is-harry wants to merge 2 commits intoSAP:masterfrom
he-is-harry wants to merge 2 commits intoSAP:masterfrom
Conversation
Contributor
he-is-harry
commented
Apr 23, 2025
he-is-harry
commented
- Fixed a bug where a callback could be called multiple times for a write lob request if several streams emitted an error between packet sends
- Fixed a deadlock which would occur if streams were destroyed before or during a write lob request
- LOB streams that are closed without an error or end event emitted will now raise an error
- Added unit and integration tests for these two situations
- Fixed a situation where a callback could be called multiple times
for a write lob request if several streams emitted an error between
packet sends
- Fixed a deadlock which would occur if streams were destroyed
before or during a write lob request
- LOB streams that are closed without an error or end event
emitted will now raise an error
- Added unit and integration tests for these two situations
Contributor
Author
|
It seems this PR was ELA'd instead of the intended #263. So, I think this PR might still need a non-author code review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.