Open
Conversation
Contributor
he-is-harry
commented
Apr 16, 2025
- Added initial isValid(timeout) check which will return true if the client can send a request to the server and receive a reply within the timeout
- timeout is given in seconds
- The API's implementation can be updated once the ping protocol support is complete on the server side
- Updated Connection.send so that it can accept a communicationTimeout option to timeout a request to the server and return a timeout error
- Added unit and integration tests for isValid
- Added initial isValid(timeout) check which will return true if the
client can send a request to the server and receive a reply within
the timeout
- timeout is given in seconds
- Updated Connection.send so that it can accept a communicationTimeout
option to timeout a request to the server and return a timeout error
- Added unit and integration tests for isValid
Contributor
Author
|
Here is a rough draft for the reconnect on timeout change: he-is-harry@bcdd7e0. TODOs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.