Accept wildcards when specifying day of week#72
Open
Redithion wants to merge 4 commits intoRykian:masterfrom
Open
Accept wildcards when specifying day of week#72Redithion wants to merge 4 commits intoRykian:masterfrom
Redithion wants to merge 4 commits intoRykian:masterfrom
Conversation
Accept not specified minutes and hour with a given weekday.
Added the new formats supported and an example
Combined two separate blocks of code into one in :at example
Author
|
I don't know why CI fails, we are using this in prod with Ruby 2.1 and Ruby 2.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to support wildcards when setting a day of week.
A use case for this is if you want to send an alert every hour only on weekdays.
Examples:
This was resolved setting
NOT_SPECIFIEDin bothminandhourwhen matching that case (/\A([[:alpha:]]+)\s\*{1,2}:\*{1,2}\z/).I've also updated the README reflecting this change.