Open
Conversation
Member
|
this is a great panda level submission. Yay! 🎉 |
Author
|
@jwo I updated this with tiger and eagle. It was a fun one. I feel like I'm getting more comfortable with identifying a cleaner interface at the top. The refactoring of the route class was a good challenge. Just a note on the benchmarking, I updated the config file in my geocoder gem to allow for more time. the default timeout is 3 seconds: |
lib/route.rb
Outdated
Member
There was a problem hiding this comment.
Totally a prefence, but I like
while remaining_points.any? do
end…culate with a while do end loop
Author
|
@jwo one more check please. |
Member
|
This looks most excellent 🎉 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.