fix: show preparing message before file path stabilizes #10856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements a two-phase UX for file editing operations: 1. Show "Roo is preparing to edit a file..." immediately when a file edit starts 2. Update to "Roo wants to edit this file" with the actual filename once path stabilizes The issue was that file paths arrive character-by-character during streaming, and the UI waited for path stabilization before showing anything, creating the appearance of a frozen UI. Changes: - Added preparingToEdit translation string to all 18 locale files - Modified ChatRow.tsx to show preparing message when tool.path is undefined - Updated CodeAccordian.tsx to show loading placeholder for undefined paths - Added hasSentInitialMessage flag to BaseTool.ts - Updated ApplyDiffTool, EditFileTool, WriteToFileTool, SearchAndReplaceTool, and SearchReplaceTool to send initial "preparing" message immediately - Updated writeToFileTool test to reflect new behavior Addresses issue #10855
Contributor
Author
Review complete. Found 1 issue that needs attention before merging.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| "wantsToFetch": "Roo quiere obtener instrucciones detalladas para ayudar con la tarea actual" | ||
| }, | ||
| "fileOperations": { | ||
| "preparingToEdit": "Roo is preparing to edit a file...", |
Contributor
Author
There was a problem hiding this comment.
The preparingToEdit string is not actually translated in this file (and 14 other non-English locale files). It contains English text "Roo is preparing to edit a file..." instead of the Spanish translation. This affects: es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, and zh-TW. Only ca and de have proper translations. Non-English users will see English text for this message.
Fix it with Roo Code or mention @roomote and request a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to address Issue #10855 by implementing a two-phase UX for file editing operations, as suggested by @Jerrill:
Problem
File paths arrive character-by-character during streaming. Previously, the UI waited for path stabilization before displaying anything, which caused the appearance of a frozen/stuck UI for several seconds.
Solution
path: undefinedimmediately when a file edit tool starts!tool.pathand shows the "preparing" messageChanges
Backend (src/core/tools/)
hasSentInitialMessageflag toBaseTool.tsto track initial message stateApplyDiffTool.tsEditFileTool.tsWriteToFileTool.tsSearchAndReplaceTool.tsSearchReplaceTool.tsFrontend (webview-ui/)
ChatRow.tsxto show "Roo is preparing to edit a file..." whentool.pathis undefinedCodeAccordian.tsxto show "Loading file..." placeholder when path is undefinedpreparingToEdittranslation string to all 18 locale filesTests
writeToFileTool.spec.tsto reflect new behaviorTesting
Related Issue
Closes #10855
Feedback and guidance are welcome!
Important
Introduces a two-phase message system for file editing operations to provide immediate user feedback, with backend and frontend updates to support this behavior.
hasSentInitialMessageflag inBaseTool.tsto track message state.ApplyDiffTool.ts,EditFileTool.ts, andWriteToFileTool.tsto send initial messages before path stabilization.ChatRow.tsxandCodeAccordian.tsxto display "preparing" messages whentool.pathis undefined.preparingToEdittranslation string to 18 locale files.writeToFileTool.spec.tsto test new behavior.Roo wants to edit this filedoesn't finish rendering until file is written #10855.This description was created by
for 5979bda. You can customize this summary. It will automatically update as commits are pushed.