added registration for nested SyncableFields#33
Open
CoreAidan wants to merge 4 commits intoRevenantX:masterfrom
Open
added registration for nested SyncableFields#33CoreAidan wants to merge 4 commits intoRevenantX:masterfrom
CoreAidan wants to merge 4 commits intoRevenantX:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability for the EntityClassData constructor to find and register nested SyncableFields and their SyncVars
Since reference types are stored in the parent object as a pointer to a separately‐allocated object I've created a map that allows for chaining to the target offset.
NOTE: this is just a rough pass idea that is not final. while it does work I don't know much about optimizations. I more or less want to get your opinion as I know the multiple calls to traverse the object is a bit much I couldn't think of another way. Though as I mention it does seem to work, but was not thoroughly test.