publish: fix ModConfig.json regex inclusion duplicate check#817
publish: fix ModConfig.json regex inclusion duplicate check#817Sewer56 merged 1 commit intoReloaded-Project:masterfrom
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughFixed duplicate-detection logic in PublishModDialogViewModel constructor to compare StringWrapper values instead of wrapper objects. Changed from direct Contains check to iterating wrapper entries and checking their Value property with case-insensitive matching. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merging in any case, as names on Windows FileSystem are case insensitive, but nonetheless; kinda curious to know. |
|
Root issue is that |
|
Ah, checks out. I didn't catch that was a stringwrapper from the web UI |

Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.