Skip to content

The "Uhh no strings for Yes and No?" update#815

Merged
Sewer56 merged 1 commit intoReloaded-Project:masterfrom
dysfunctionalriot:master
Jan 27, 2026
Merged

The "Uhh no strings for Yes and No?" update#815
Sewer56 merged 1 commit intoReloaded-Project:masterfrom
dysfunctionalriot:master

Conversation

@dysfunctionalriot
Copy link
Contributor

@dysfunctionalriot dysfunctionalriot commented Jan 27, 2026

Adds the new strings up to the new yes/no

Summary by CodeRabbit

  • New Features

    • Added new French language messages for missing or unsupported applications and for application selection prompts.
  • Bug Fixes

    • Added new Yes/No entries in French, which may address incomplete translations but could cause conflicts if duplicates exist.

✏️ Tip: You can customize this high-level summary in your review settings.

Adds the new strings up to the new yes/no
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

French language resource strings were added to the launcher's localization file, including new messages for application selection and missing/incompatible application scenarios. Two Yes/No string entries were also appended, potentially duplicating existing keys.

Changes

Cohort / File(s) Summary
French Language Localization
source/Reloaded.Mod.Launcher/Assets/Languages/fr-FR.xaml
Added 5 new UI string resources: NoAppsInConfigTitle, NoAppsInConfigDescription, NoCompatibleAppsInConfigTitle, NoCompatibleAppsInConfigDescription, AppSelectionQuestion. Added duplicate Yes and No string entries at end of file that may conflict with existing keys if not reconciled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Translations hop along with care,
French whispers float through UI air,
New messages bloom, yet one thing's clear—
Those duplicate keys might cause a tear! 🇫🇷


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sewer56 Sewer56 merged commit 1f995f3 into Reloaded-Project:master Jan 27, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants