Update step length selection in LAED4 overshoot fallback#1191
Open
angsch wants to merge 1 commit intoReference-LAPACK:masterfrom
Open
Update step length selection in LAED4 overshoot fallback#1191angsch wants to merge 1 commit intoReference-LAPACK:masterfrom
angsch wants to merge 1 commit intoReference-LAPACK:masterfrom
Conversation
langou
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On behalf of the NVIDIA cuSolver team, I am proposing a fix of #1166.
When LAED4 overshoots, bisection is used as fallback. This was introduced with LAPACK 3.0. This MR updates the heuristic to account for cases where the bisection step is a poor choice: The relative distance is large (details in the issue), and the step can be too large, increasing the objective function value a lot. The new heuristic exploits that we know that the root is close to a cell boundary if we enter the fallback branch. As a consequence, we know that a plain Newton step is too short; a bisection step is be too long if we are far away from the cell boundary; so we combine both by using the geometric mean for a more balanced step length selection. If we are close to cell boundary, the bisection step and the Newton step are essentially the same, so there is no difference in that case.
The iterations marked with * go into the fallback branch; the objective function value
Wis much better than with plain bisection (compare with table in bug report). Instead of 31 iterations and 3 overshoots as in the bug report, we now have 15 iterations and only 2 overshoots.Checklist