Adds some docstring to pybind function and some refactors#133
Merged
StephenNneji merged 2 commits intoRascalSoftware:mainfrom Feb 24, 2025
Merged
Adds some docstring to pybind function and some refactors#133StephenNneji merged 2 commits intoRascalSoftware:mainfrom
StephenNneji merged 2 commits intoRascalSoftware:mainfrom
Conversation
StephenNneji
force-pushed
the
add_pybind_docs
branch
2 times, most recently
from
71c4e96 to
2926195
Compare
alexhroom
reviewed
Feb 18, 2025
alexhroom
requested changes
Feb 19, 2025
Collaborator
alexhroom
left a comment
alexhroom
left a comment
There was a problem hiding this comment.
looks mostly there, just a few things to clarify
StephenNneji
force-pushed
the
add_pybind_docs
branch
from
83f9ef9 to
408c0ef
Compare
alexhroom
approved these changes
Feb 24, 2025
Collaborator
alexhroom
left a comment
alexhroom
left a comment
There was a problem hiding this comment.
all good apart from a typo!
Co-authored-by: Alex H. Room <69592136+alexhroom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129