fix: iterate individual resblock hooks instead of parent container hooks#2756
Open
Mr-Neutr0n wants to merge 1 commit intoRVC-Project:mainfrom
Open
fix: iterate individual resblock hooks instead of parent container hooks#2756Mr-Neutr0n wants to merge 1 commit intoRVC-Project:mainfrom
Mr-Neutr0n wants to merge 1 commit intoRVC-Project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneratorNSF.__prepare_scriptable__()ininfer/lib/infer_pack/models.py(line 586)for l in self.resblocks:loop was iterating overself.resblocks._forward_pre_hooks(the parentnn.ModuleListcontainer's hooks) instead ofl._forward_pre_hooks(each individual resblock's hooks)Details
The identical pattern appears correctly in two other places in the same file:
Generator.__prepare_scriptable__()(line 297) — correctly usesl._forward_pre_hooksGeneratorNSF.__prepare_scriptable__()forself.ups(line 575) — correctly usesl._forward_pre_hooksOnly the
self.resblocksloop inGeneratorNSF.__prepare_scriptable__()had this bug.Test plan
GeneratorNSF.__prepare_scriptable__()correctly removes weight norm from individual resblocks when preparing for TorchScript