Open
Conversation
cako
approved these changes
Feb 9, 2026
cako
left a comment
There was a problem hiding this comment.
Looks really good! The website looks great. Left a few comments. For some improvements I'd consider:
- Use nox for local testing different Python versions
- Retire Makefile (doesn't work natively on Windows, but nox does)
- Default to uv, then conda, then pip.
Also, for the segmentation.py example to work, I need to crank up the maxiter to 30. Otherwise I get:
r = _zeros._bisect(f, a, b, xtol, rtol, maxiter, args, full_output, disp)
RuntimeError: Failed to converge after 20 iterations.| "numpy >= 1.21.0", | ||
| "scipy >= 1.11.0", | ||
| "pylops >= 2.0.0", | ||
| "typing_extensions", |
There was a problem hiding this comment.
Suggest using typing_extensions>=4.0.0 since it's when they started using semantic versioning.
| 'examples_dirs': ['../../examples', '../../tutorials',], | ||
| # path where to save gallery generated examples | ||
| 'gallery_dirs': ['gallery', 'tutorials'], | ||
| 'filename_pattern': '\.py', |
There was a problem hiding this comment.
This line complains when I run docs. Two suggestions: format this file with ruff and use raw string (r"\.py").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for UV to PyProximal:
pyproject.tomluv.lock*MakefileIt also modernizes the overall tooling:
setup.cfgtopyproject.tomlFinally, it contains various improvements to the documentation:
sphinx-designto have tabs in installation instructions for conda/pip/uv