This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Added duration converter and time formatter#129
Open
LoCrealloc wants to merge 16 commits intodevelopfrom
Open
Conversation
Deploying with
|
| Latest commit: |
e964002
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://754128c8.pydrocsid-library.pages.dev |
| Branch Preview URL: | https://feature-durationconverter.pydrocsid-library.pages.dev |
LoCrealloc
added
enhancement
Tristan-H11
suggested changes
Jul 12, 2022
Co-authored-by: Tristan <45330667+Tristan-H11@users.noreply.github.com>
Co-authored-by: Tristan <45330667+Tristan-H11@users.noreply.github.com>
…feature/durationconverter # Conflicts: # PyDrocsid/util.py
Tristan-H11
suggested changes
Jul 13, 2022
Member
|
Die Docs sind richtig geil :) |
Member
|
Gleiche Commits wie bspw deine Verbesserung der Docstrings oder das verbesserte Typing darfst du auch gerne squashen, wenn die eh direkt nacheinander kommen. Das macht hier nicht allzu viel aus, aber ist eigentlich eine gute Angewohnheit, solange die commits dann nicht zu groß werden. Dann hat man alles schön fachlich zusammengehörig und man reviewed nicht zwei commits am stück und beide sind inhaltlich ähnlich. ^^ |
Tristan-H11
previously approved these changes
Jul 13, 2022
|
Code Climate has analyzed commit e964002 and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the duration converter and minute to time units formatter.
As those features depend on the dateutil package, it was added to the project requirements.