Skip to content

Fix/getcloser security config#345

Merged
soohyunme merged 2 commits intomainfrom
fix/getcloser-security-config
Feb 7, 2026
Merged

Fix/getcloser security config#345
soohyunme merged 2 commits intomainfrom
fix/getcloser-security-config

Conversation

@soohyunme
Copy link
Member

๐Ÿ“ PR ํƒ€์ž…

  • ๋ฒ„๊ทธ ์ˆ˜์ • (fix)
  • ์‹ ๊ทœ ๊ธฐ๋Šฅ (feat)
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ (docs)
  • ์ฝ”๋“œ ์Šคํƒ€์ผ / ํฌ๋งทํŒ… (style)
  • ๋ฆฌํŒฉํ† ๋ง (refactor)
  • ํ…Œ์ŠคํŠธ (test)
  • ๊ธฐํƒ€ (chore)

๐Ÿ”จ ์ž‘์—… ๋‚ด์šฉ

getcloser ์„œ๋น„์Šค์˜ ๋ณด์•ˆ ์„ค์ •์„ ๊ฐ•ํ™”ํ•˜๊ณ  ํ™˜๊ฒฝ ๋ณ€์ˆ˜ ๊ด€๋ฆฌ๋ฅผ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

  1. SECRET_KEY ๊ด€๋ฆฌ ๊ฐ•ํ™” (getcloser/backend/app/core/config.py)
  • SECRET_KEY์˜ ๊ธฐ๋ณธ๊ฐ’์„ ์ œ๊ฑฐํ•˜๊ณ , ENVIRONMENT๊ฐ€ prod ๋˜๋Š” production์ผ ๋•Œ ํ™˜๊ฒฝ ๋ณ€์ˆ˜๊ฐ€ ์„ค์ •๋˜์ง€ ์•Š์•˜๊ฑฐ๋‚˜ ๊ธฐ๋ณธ๊ฐ’์„ ๊ทธ๋Œ€๋กœ ์‚ฌ์šฉ ์ค‘์ด๋ฉด ์„œ๋ฒ„ ์‹œ์ž‘์„ ์ฐจ๋‹จํ•˜๋„๋ก Pydantic validator๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  1. ํ™˜๊ฒฝ ๋ณ€์ˆ˜ ๊ฐ€์ด๋“œ ์ถ”๊ฐ€ (getcloser/backend/.env.example)
  • ๋ณด์•ˆ ์„ค์ •์„ ์œ„ํ•œ .env.example ํŒŒ์ผ์„ ์ƒ์„ฑํ•˜๊ณ , openssl์„ ์ด์šฉํ•œ ์‹œํฌ๋ฆฟ ํ‚ค ์ƒ์„ฑ ๋ฐฉ๋ฒ•์„ ์ฃผ์„์œผ๋กœ ์•ˆ๋‚ดํ–ˆ์Šต๋‹ˆ๋‹ค.
  1. ๋ฐฐํฌ ์›Œํฌํ”Œ๋กœ์šฐ ์ˆ˜์ • (.github/workflows/deploy-getcloser.yml)
  • GitHub Actions ๋ฐฐํฌ ์‹œ SECRET_KEY์™€ ENVIRONMENT=prod ๋ณ€์ˆ˜๊ฐ€ .env ํŒŒ์ผ์— ์ฃผ์ž…๋˜๋„๋ก ์Šคํ…์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

์—ฎ์ธ ์ด์Šˆ

  • Closes #

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

(ํ•ด๋‹น ์—†์Œ - ๋ฐฑ์—”๋“œ ์„ค์ • ๋ฐ CI ์ˆ˜์ •)


๐Ÿง‘โ€๐Ÿ’ป ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ

  • ๋กœ์ปฌ ํ™˜๊ฒฝ(ENVIRONMENT=dev)์—์„œ ์„œ๋ฒ„ ์ •์ƒ ๊ตฌ๋™ ํ™•์ธ.
  • SECRET_KEY ํ™˜๊ฒฝ ๋ณ€์ˆ˜๋ฅผ ์ œ๊ฑฐํ•˜๊ณ  ENVIRONMENT=prod๋กœ ์„ค์ • ์‹œ ์„œ๋ฒ„ ๊ตฌ๋™ ์‹คํŒจ(Validation Error) ํ™•์ธ.

๐Ÿ“… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ดํ•ดํ•˜๊ธฐ ์–ด๋ ค์šด ๋ถ€๋ถ„์— ์ฃผ์„์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ด€๋ จ๋œ ๋ฌธ์„œ๋ฅผ ์—…๋ฐ์ดํŠธํ–ˆ์Šต๋‹ˆ๋‹ค. (.env.example)

@soohyunme soohyunme merged commit 81491dd into main Feb 7, 2026
2 checks passed
@soohyunme soohyunme deleted the fix/getcloser-security-config branch February 7, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant