feat: enhance platform access logging with ip hash and unify salt config#344
Merged
feat: enhance platform access logging with ip hash and unify salt config#344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
๐ PR ํ์
๐จ ์์ ๋ด์ฉ
Platform
access_log์ip_hashํ๋๋ฅผ ์ถ๊ฐํ์ฌ ๊ฐ์ธ์ ๋ณด๋ฅผ ๋ณดํธํ๋ฉด์๋ ๋ฐฉ๋ฌธ์ ์๋ณ์ด ๊ฐ๋ฅํ๋๋ก ๊ฐ์ ํ์ต๋๋ค.X-Forwarded-Forํค๋์์ ์ค์ ํด๋ผ์ด์ธํธ IP๋ฅผ ์ถ์ถํ๋ getClientIp ํจ์๋ฅผ ๊ตฌํํ์ต๋๋ค.ACCESS_LOGGING_IP_SALT๋ฅผ ์ฌ์ฉํ์ฌSHA-256ํด์ฑ์ ์ ์ฉํ๊ณ , ์ด๋ฅผ .env.example, docker-compose.yml, GitHub Actions ์ํฌํ๋ก์ฐ์ ๋ฐ์ํ์ฌ ์ค์ ๋๋ฝ์ด ์๋๋ก ํ์ต๋๋ค.์ฎ์ธ ์ด์
๐ธ ์คํฌ๋ฆฐ์ท
๐งโ๐ป ํ ์คํธ ๊ฒฐ๊ณผ
๐ ์ฒดํฌ๋ฆฌ์คํธ