Open
Conversation
They are put in SearchUtils.kt - still not ideal but better than before.
CurrentUserLocalSettingsManager used to change the enabled status of custom DNS depending on the DNS list updates. This logic has been removed, the toggle is only changed by the settings view model when adding a new DNS item. The `enabled` field is renamed to `switchEnabled` to explicitly state it's about the UI toggle, not feature as a whole. `effectiveEnabled` should be used in most places..
It should catch issues like renamed fields.
…esso and Compose framework
When Custom DNS is enabled in profile the NetShield setting in main settings should show "Unavailable" with the profile chip.
…en navigating back [VPNAND-2360]
…back to main screen [VPNAND-2360]
Author
|
Hope this time gets the merged |
AlgirdasPundzius
force-pushed
the
master
branch
from
bb99f47 to
2e2156b
Compare
AlgirdasPundzius
force-pushed
the
master
branch
2 times, most recently
from
4758d31 to
cc9b682
Compare
AlgirdasPundzius
force-pushed
the
master
branch
2 times, most recently
from
2a07680 to
6c1a79f
Compare
AlgirdasPundzius
force-pushed
the
master
branch
from
6c1a79f to
9e97f18
Compare
3 tasks
AlgirdasPundzius
force-pushed
the
master
branch
from
9e97f18 to
aaa3fc7
Compare
AlgirdasPundzius
force-pushed
the
master
branch
from
aaa3fc7 to
ca69096
Compare
AlgirdasPundzius
force-pushed
the
master
branch
from
ca69096 to
04d0154
Compare
AlgirdasPundzius
force-pushed
the
master
branch
from
04d0154 to
c99f8fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.