Open
Conversation
- Add run_config field to RLConfig for TOML parsing - Add run_config parameter to RLClient.create_run() - Pass run_config from CLI to API - Update config template with example
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| payload["max_async_level"] = max_async_level | ||
|
|
||
| if run_config: | ||
| payload["run_config"] = run_config |
There was a problem hiding this comment.
Inconsistent payload key breaks config naming pattern
Medium Severity
The run_config parameter uses payload["run_config"] as its key, but the established pattern for similar configs uses shortened names without the _config suffix: eval_config → "eval", val_config → "val", buffer_config → "buffer". If the backend API follows this same naming convention, it would expect "run" as the key rather than "run_config", causing the configuration to be silently ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for passing
run_configthrough the CLI via TOML config files.[run_config]section in TOMLNote
Introduces advanced
run_configsupport in RL workflows.[run_config]in CLI TOML via newRLConfig.run_configand include example in the generated templaterun_configparameter toRLClient.create_runand include it in the request payload when providedget_distributionsWritten by Cursor Bugbot for commit 02e1ecd. This will update automatically on new commits. Configure here.