Added 'haslore' and 'loreequalsmulti:<String>' modifiers#66
Open
TomTeDev wants to merge 1 commit intoPlaceholderAPI:masterfrom
Open
Added 'haslore' and 'loreequalsmulti:<String>' modifiers#66TomTeDev wants to merge 1 commit intoPlaceholderAPI:masterfrom
TomTeDev wants to merge 1 commit intoPlaceholderAPI:masterfrom
Conversation
cj89898
requested changes
Feb 9, 2024
| } | ||
|
|
||
| public boolean hasLore() { | ||
| return this.lore != null && !this.lore.isEmpty(); |
Contributor
There was a problem hiding this comment.
the hasLore method for the item wrapper seems to be returning wrong information.
It returns true/false dependent on if the WRAPPER has lore and if it's not empty.
It should be returning true/false dependent on if haslore is in the placeholder or not, nothing to do with the wrapper.
Contributor
There was a problem hiding this comment.
In fact, this method could probably just be removed entirely.
| if (wrapper.shouldCheckHasLore()) { | ||
| data = multiMod ? data += "haslore:" : ""; | ||
| if (item.hasItemMeta()) { | ||
| data += item.getItemMeta().hasLore() ? "yes" : "no"; |
Contributor
There was a problem hiding this comment.
Should be using PlaceholderAPIPlugin boolean values PlaceholderAPIPlugin.booleanTrue() PlaceholderAPIPlugin.booleanFalse()
| } | ||
| if (wrapper.shouldCheckNameEquals()) | ||
| meta.setDisplayName(wrapper.getName()); | ||
| if (wrapper.shouldCheckLoreEquals() || wrapper.shouldCheckMultiLoreEquals() || wrapper.shouldCheckHasLore()) { |
Contributor
There was a problem hiding this comment.
shouldCheckHasLore() should not be included here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.