Fix Implicitly marking parameter $maxItems as nullable is deprecated#1
Merged
PhrozenByte merged 3 commits intoPhrozenByte:masterfrom Sep 24, 2025
Merged
Fix Implicitly marking parameter $maxItems as nullable is deprecated#1PhrozenByte merged 3 commits intoPhrozenByte:masterfrom
PhrozenByte merged 3 commits intoPhrozenByte:masterfrom
Conversation
29a1b98 to
43614f1
Compare
Owner
|
Thanks! ❤️ I just additionally updated the CI to check up to PHP 8.4 and fixed the same deprecation notices in the test suite. Unfortunately the same deprecations also affect Psalm 4 which therefore doesn't work with PHP 8.4. So, no static code analysis for PHP 8.4… 😒 See #2 for details. Help is very welcome (like any other PR, too, btw). I just pushed a new tag for both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.