Fixed for #1474 Updating CalcDefense for it to consider items like Starkonja's, Rise of the Pheonix when is use with a different low life modifies items like Coward Legacy.#1704
Conversation
Wires77
left a comment
There was a problem hiding this comment.
I think the proper fix looks something like this: PathOfBuildingCommunity/PathOfBuilding#9351
That PR is for PoB1, and all this code was changed in #79, but we may just want to calculate these values earlier totally. This may allow us to replace the lower calls to doActorLifeManaSpirit. Doesn't seem to make much sense to call it so many times.
I'm trying to keep parity with the ordering of calculations, since we've divined them slowly over the years and moving things around in the Calc files causes frequent bugs if we get the ordering wrong. I think the way you have it in this PR would break any calculation like https://www.poewiki.net/wiki/Crimson_Power if they added it to PoE2
CalcDefences
This reverts commit 45398e6.
|
The mentioned method in the PoB1 issue fixed the bug, so I reverted my original changes and put in the same fix. |
Fixes # 1474.
Description of the problem being solved:
The issue was to fix the Coward's Legacy belt lowlife modifiers not working correctly. This was wrong since it worked correctly, verified by using the Pain Atunement note that 75% Lowlife is accounted correctly with Beidat's Hand. So the thing that doesn't work is the defense's calculation of items like Starkonja's Head or Rise of the Phoenix. So I solved the problem by changing calcs.defence functions.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/R8tUNGCcbxCR
Before screenshot:
After screenshot: