Open
Conversation
Collaborator
|
@colton-smith is this ready for review yet or still WIP? |
Contributor
Author
|
@Burke-Daniel |
colton-smith
commented
Jun 6, 2021
Contributor
Author
colton-smith
left a comment
colton-smith
left a comment
There was a problem hiding this comment.
Couple of things I need to fix here stylewise
| class BoringPacket(): | ||
| """ Create and pack The Boring Struct | ||
| """ | ||
| raise NotImplementedError No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
new newline EOF
| sock.sendto(MESSAGE, (UDP_IP, UDP_PORT)) | ||
| print("Message sent...\n") | ||
| time.sleep(1/SEND_FREQUENCY) | ||
|
No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Whats going on here
| timeout: timedelta - how long to poll for data on the socket before timing out | ||
| """ | ||
|
|
||
| def __init__(self, ip : str, port : int, max_buffer : int, timeout : timedelta): |
Contributor
Author
There was a problem hiding this comment.
What is this typehinting style??
Burke-Daniel
approved these changes
Jun 6, 2021
Collaborator
Burke-Daniel
left a comment
Burke-Daniel
left a comment
There was a problem hiding this comment.
Couple little style things we discussed on call but after that GTM!
Comment on lines
+75
to
+81
| def __str__(self): | ||
| ret_str = f"""UDP Connection: | ||
| \nIp: {self.ip} | ||
| \nPort: {self.port} | ||
| \nBuffer Size: {self.max_buffer_size} | ||
| """ | ||
| return ret_str |
| con = UDPListener(VEHICLE_IP, VEHICLE_UDP_PORT, 1024, timedelta(seconds=2)) | ||
| con.connect() | ||
|
|
||
| counter = 5 |
Collaborator
There was a problem hiding this comment.
This doesn't seem to be getting used anywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief
WIP - Porting the PDS from competition 4.
Completed So far:
UDPListenerclass, a port of thePodUdpConnectionclassNeed to add: