feat: basic_node allocation and aug_node iterate method#4
Open
RomaLzhih wants to merge 1 commit intoParAlg:mainfrom
Open
feat: basic_node allocation and aug_node iterate method#4RomaLzhih wants to merge 1 commit intoParAlg:mainfrom
RomaLzhih wants to merge 1 commit intoParAlg:mainfrom
Conversation
RomaLzhih
commented
Jun 5, 2025
RomaLzhih
commented
- The basic::compressed_node should allocate memory based on its size, rather than the hard-coded value, which may bring trouble when the developer wants to change the node structure.
- When traversing the tree in augmented_node, one should cast the node to the augmented_node type rather than the basic node, as this may incur a different offset when access the encoded_data.
- The basic_node should alloc memory based on its size, rather than the hard-coded size, which may bring trouble when developer may want to change the node structure. - When traverse the tree in augmented_node, one should cast the node to augmented_node type rather the basic node, as this may incur different offset problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.