-
Notifications
You must be signed in to change notification settings - Fork 186
605 logical routers should be attachable to vsys objects #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
605 logical routers should be attachable to vsys objects #606
Conversation
shinmog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like logical routers were added in PAN-OS 10.2...?
If that's the case, then the code for this needs to reflect that. You can refer to this code to see how to add a param for something that only started existing in a particular version:
https://github.com/PaloAltoNetworks/pan-os-python/blob/develop/panos/network.py#L155-L165
|
@shinmog I added this, I think i got it right? In this way the parameter is excluded for PANOS < |
shinmog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it was Google's AI that said PAN-OS 10.2. I'd just ask that you verify that as true, but otherwise the code looks spot on, so I'll approve it.
|
@alperenkose @horiagunica look ok to you guys as well? |
This PR enables vsys handling for logical routers.