🪲 [Fix]: Access to GH_TOKEN and Get-Settings for Name#171
Merged
MariusStorhaug merged 3 commits intomainfrom Jun 2, 2025
Merged
🪲 [Fix]: Access to GH_TOKEN and Get-Settings for Name#171MariusStorhaug merged 3 commits intomainfrom
MariusStorhaug merged 3 commits intomainfrom
Conversation
… and adding GH_TOKEN environment variable
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the GitHub Actions workflow for publishing the PowerShell module by adding proper authentication and simplifying inputs.
- Adds a GitHub token environment variable (
GH_TOKEN) for authentication - Removes unused inputs (
Debug,Prerelease,Verbose,Version) - Introduces a
WorkingDirectoryinput to explicitly set the module path
Comments suppressed due to low confidence (2)
.github/workflows/workflow.yml:290
- The
github.tokencontext isn't available in workflows. Usesecrets.GITHUB_TOKENinstead (e.g.,GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}) to ensure the token is loaded correctly.
GH_TOKEN: ${{ github.token }}
.github/workflows/workflow.yml:305
- Verify that
WorkingDirectoryis defined underon.workflow_dispatch.inputsor given a default value, so the workflow won't fail if this input is omitted.
WorkingDirectory: ${{ inputs.WorkingDirectory }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes updates to the workflow files to improve clarity and functionality. The changes primarily focus on refining conditional logic in PowerShell scripts and enhancing environment variable handling in GitHub Actions.
Workflow improvements:
.github/workflows/Get-Settings.yml: Updated the conditional logic for determining the$namevariable to use explicitif-elseif-elsestatements, improving readability and maintainability.Environment variable and input adjustments:
.github/workflows/workflow.yml: Added theGH_TOKENenvironment variable to thePublish modulestep to ensure authentication is handled securely..github/workflows/workflow.yml: Reintroduced theWorkingDirectoryinput to thePublish modulestep for better modularity and flexibility in specifying paths.Type of change
Checklist