allow account reset codebuild access to custom nuke config bucket #issue409#412
Open
morganpa wants to merge 2 commits intoOptum:masterfrom
Open
allow account reset codebuild access to custom nuke config bucket #issue409#412morganpa wants to merge 2 commits intoOptum:masterfrom
morganpa wants to merge 2 commits intoOptum:masterfrom
Conversation
|
|
8f50903 to
b3f2b6f
Compare
b3f2b6f to
c00454a
Compare
|
@jayanandagit any update here? We're looking to consume DCE in the next month or so but it won't work with our stack if we don't have this custom nuke config. |
thebigcosinus
approved these changes
Nov 18, 2021
|
Any chance to update aws-nuke to new version to cover new services? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allow account reset codebuild to access s3 bucket and key for custom aws nuke yaml
fix for #409
Types of changes
Checklist
README.md, inline comments, etc.)CHANGELOG.mdunder a## nextrelease, with a short summary of my changesRelevant Links
Further comments