[Android]Rework Optable API configuration and request forming by ValentinPostindustria · Pull Request #35 · Optable/optable-android-sdk

ValentinPostindustria · 2025-11-17T13:57:23Z

Closes #33.

Breaking changes:

Remove app path parameter.
Add tenant and originSlug query parameters.
Make host dynamic and apply path v2.

Other features:

Support apiKey.
Move all configuration parameters in Config class and reuse it everywhere.
Separate GoogleAdIdManager and LocalStorage logic from the network client.
Rename Client to NetworkClient.
Move hash logic to separate TypeHasher class.
Separate network interceptors.
Demo apps are built using local SDK.
Unit tests with mock web server.
Build WebView for user agent only once and cache the result.
Apply automatic IDEA aligning.

Remove `app` path parameter. Add `tenant` and `originSlug` parameters. Make host dynamic and apply path `v2`. Move all configuration parameters in Config class and reuse it everywhere. Separate `GoogleAdIdManager` and `LocalStorage` logic from the network client. Rename `Client` to `NetworkClient`. Move hash logic to separate `TypeHasher` class. Separate network interceptors. Refactor SDK code.

Support secret api keys. Fetch user agent only once. Write unit tests with the mock web server.

android_sdk/src/main/java/co/optable/android_sdk/OptableSDK.kt

android_sdk/src/main/java/co/optable/android_sdk/core/UserAgentHolder.kt

android_sdk/src/main/java/co/optable/android_sdk/OptableSDK.kt

Remove custom network Adapter. Use native Retrofit adapter. Add Kotlin suspension.

Migrate from TypeHasher to IdentifiersEncoder. Add all identifier types. Cover with unit tests.

Use callbacks API. Rewrite demo apps to make the examples more readable. Use shorter logs. Create Optable SDK instance once during application creation and reuse everywhere. Move fragments to one folder.

Add missed "reg" query param. Make Consents mutable. Provide `receiveGaidAutomatically` property. Refactor main methods javadoc.

DemoApp/DemoAppJava/app/src/main/java/co/optable/demoappjava/TheApplication.java

DemoApp/DemoAppJava/app/src/main/java/co/optable/demoappjava/ui/GamBannerFragment.java

DemoApp/DemoAppJava/app/src/main/java/co/optable/demoappjava/ui/PrebidBannerFragment.java

DemoApp/DemoAppKotlin/app/src/main/java/co/optable/androidsdkdemo/ui/GamBannerFragment.kt

android_sdk/src/main/java/co/optable/android_sdk/OptableSDK.kt

android_sdk/src/main/java/co/optable/android_sdk/core/IdentifiersEncoder.kt

android_sdk/src/main/java/co/optable/android_sdk/OptableIdentifiers.kt

android_sdk/src/test/java/co/optable/android_sdk/OptableIdentifiersTest.kt

justadreamer · 2026-01-19T12:00:26Z

Kotlin Demo App:

Are these warnings ok? Can we do anything to eliminate them?

Identify API call does not show any details - we need to see request and response - see how it is done on iOS

The same should be done for GAM Banner and Prebid. Compare Android and iOS:

justadreamer

LGTM

android_sdk/src/main/java/co/optable/android_sdk/core/network/NetworkClient.kt

android_sdk/src/main/java/co/optable/android_sdk/OptableSDK.kt

Change public API to accept list of OptableIdentifier. Rewrite encoder. Restore unit tests.

justadreamer · 2026-02-13T16:35:48Z

android_sdk/src/main/java/co/optable/android_sdk/OptableTraits.kt

+ * @param id The identifier that traits and neighbors will be linked to. This value takes precedence over the passport if provided.
+ * @param neighbors An array of identifiers to link to the id or passport
+ */
+data class OptableTraits @JvmOverloads constructor (


This class encapsulates parameters to the profile API call, perhaps it makes sense to name it OptableProfileParams. Ideally we should make this class private and make the public profile API take traits,id, neighbors as raw parameters, not nested inside the object. This will be consistent with iOS impelmentation. Internally these params can be set into this object and it can be passed to other internal calls, just not exposed to the public via facade API.

zapo · 2026-02-13T21:42:38Z

android_sdk/src/main/java/co/optable/android_sdk/core/GoogleAdIdManager.kt

+
+            MainScope().launch {
+                adId = adInfo?.id
+                limitAdTracking = adInfo?.isLimitAdTrackingEnabled


We don't seem to use this anywhere. I'm not sure we should set the adId in IdentifiersEncoder if isLimitAdTrackingEnabled as it would lead to "00000000-0000-0000-0000-000000000000" identifier being sent.

zapo · 2026-02-13T21:46:06Z

android_sdk/src/main/java/co/optable/android_sdk/core/IdentifiersEncoder.kt

+            val uri = urlString.lowercase(Locale.ROOT).toUri()
+            val id = uri.getQueryParameter("oeid")
+
+            val wrongId = (id == null) || (id.length != 64) || (id.matches("^[a-f0-9]$".toRegex()))


This regex matches exactly a single char. Likely miss + quantifier

zapo · 2026-02-13T21:47:58Z

README.md


 ```kotlin
-MainActivity.OPTABLE = OptableSDK(this, "dcn.customer.com", "my-app", false, "custom-ua")
+val ids = OptableIdentifiers(


This no longer exists, the README need to be revisited to match the API change

zapo · 2026-02-13T21:49:14Z

README.md

+private fun applyOptableToGam(builder: AdManagerAdRequest.Builder, targeting: OptableTargeting?) {
+  if (targeting == null) return
+
+  val audiences = targeting.audiences


Should be gamTargetingKeywords

zapo · 2026-02-13T21:52:42Z

android_sdk/src/main/java/co/optable/android_sdk/core/GoogleAdIdManager.kt

+        GlobalScope.launch {
+            var adInfo: AdvertisingIdClient.Info? = null
+            try {
+                adInfo = AdvertisingIdClient.getAdvertisingIdInfo(config.context)


Is this async? Can this race with the first identify() call?

zapo · 2026-02-13T21:53:41Z

android_sdk/src/main/java/co/optable/android_sdk/OptableResponse.kt

+ *  of the API response object. On error, the response `message` string provides a description
+ *  of the error and related debug information.
+ */
+data class OptableResponse<out T>(val status: Status, val data: T?, val message: String?) {


This class is not being used anywhere but tests

ValentinPostindustria added 5 commits November 17, 2025 14:53

fix: unit tests

8d6e1de

feat: new unique suffix

7efd435

feat: use local SDK sources by default

dc6b91f

feat: api key and testing

71fe63a

Support secret api keys. Fetch user agent only once. Write unit tests with the mock web server.

ValentinPostindustria marked this pull request as ready for review November 21, 2025 09:07

ValentinPostindustria requested a review from zapo November 21, 2025 09:08

justadreamer requested changes Dec 15, 2025

View reviewed changes

ValentinPostindustria added 2 commits December 15, 2025 13:47

feat: introduce OptableConfig

ad8359b

fix: unit tests

5ae14c5

ValentinPostindustria requested a review from justadreamer December 15, 2025 13:01

ValentinPostindustria and others added 15 commits December 18, 2025 12:35

Introduce Optable demo cases with Prebid (#32)

ec71ba5

feat: refactor network layer

c6381b3

feat: introduce callbacks for identify and targeting methods

dd4ad43

feat: rewrite demo apps to use callbacks

63ba731

refactor: examples

674a426

feat: rewrite network logic

bbb6638

Remove custom network Adapter. Use native Retrofit adapter. Add Kotlin suspension.

feat: introduce OptableIdentifiers

0ee30b3

Migrate from TypeHasher to IdentifiersEncoder. Add all identifier types. Cover with unit tests.

feat: Rx LiveData to traditional callbacks

ff2bbcf

feat: targeting keywords for GAM

ade2a26

feat: refactor demo apps

fd0300d

Use callbacks API. Rewrite demo apps to make the examples more readable. Use shorter logs. Create Optable SDK instance once during application creation and reuse everywhere. Move fragments to one folder.

feat: support consents

07c7ff4

refactor: some methods

8e464dc

docs: rewrite README file

3aff74c

test: consent query params

2b8c7eb

feat: corrections

bf7a416

Add missed "reg" query param. Make Consents mutable. Provide `receiveGaidAutomatically` property. Refactor main methods javadoc.

justadreamer requested changes Jan 11, 2026

View reviewed changes

ValentinPostindustria added 3 commits January 12, 2026 20:02

feat: rename audiences to gamTargetingKeywords

6f8e459

fix: use keyspace instead of provider for the key of GAM targeting

2f98ab2

refactor: rename generateEnrichedIds

f8c4255

ValentinPostindustria added 2 commits January 15, 2026 17:47

feat: correct targetingData in OptableTargeting

1c3944f

feat: remove legacy targeting method

0da1616

ValentinPostindustria added 4 commits January 19, 2026 14:46

feat: use custom Coroutine scope

76e9408

refactor: demo examples

50830db

feat: update version to 1.0.0

0075724

fix: build

535a0fa

eugenedorfman-optable requested review from eugenedorfman-optable and removed request for eugenedorfman-optable and justadreamer January 19, 2026 17:46

justadreamer approved these changes Jan 19, 2026

View reviewed changes

eugenedorfman-optable changed the title ~~Rework Optable API configuration and request forming~~ [Android]Rework Optable API configuration and request forming Jan 19, 2026

ValentinPostindustria added 3 commits January 29, 2026 14:46

feat: configure Kover for Kotlin test coverage

8852933

feat: improve test coverage

f060d06

feat: profile API returns OptableTargeting data

5d5c648

zapo reviewed Feb 2, 2026

View reviewed changes

android_sdk/src/main/java/co/optable/android_sdk/core/network/NetworkClient.kt Outdated Show resolved Hide resolved

zapo reviewed Feb 2, 2026

View reviewed changes

android_sdk/src/main/java/co/optable/android_sdk/OptableSDK.kt Outdated Show resolved Hide resolved

ValentinPostindustria added 3 commits February 5, 2026 19:54

feat: public API with OptableIdentifier list

1ff85a3

Change public API to accept list of OptableIdentifier. Rewrite encoder. Restore unit tests.

feat: ability to send Optable traits with ids

37dc742

feat: improve test coverage

5342ef8

ValentinPostindustria requested review from justadreamer and zapo February 6, 2026 17:45

eugenedorfman-optable requested a review from jrosendahl-opt February 12, 2026 15:16

justadreamer requested changes Feb 13, 2026

View reviewed changes

zapo reviewed Feb 13, 2026

View reviewed changes

Conversation

ValentinPostindustria commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justadreamer commented Jan 19, 2026

Kotlin Demo App:

Uh oh!

justadreamer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

justadreamer Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

zapo Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zapo Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zapo Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

zapo Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

zapo Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

zapo Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ValentinPostindustria commented Nov 17, 2025 •

edited

Loading

zapo Feb 13, 2026 •

edited

Loading

zapo Feb 13, 2026 •

edited

Loading