Skip to content

Add subsribedTemplateIds to RunnerRegister #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasonopslevel wants to merge 1 commit into from
Closed

Add subsribedTemplateIds to RunnerRegister #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,21 @@ type RunnerScale struct {
RecommendedReplicaCount int `json:"recommendedReplicaCount"`
}

func (client *Client) RunnerRegister() (*Runner, error) {
func (client *Client) RunnerRegister(subscribedTemplateIds ...int) (*Runner, error) {
var m struct {
Payload struct {
Runner Runner
Errors []Error
} `graphql:"runnerRegister"`
} `graphql:"runnerRegister(subscribedTemplateIds: $subscribedTemplateIds)"`
}
v := PayloadVariables{}
if len(subscribedTemplateIds) > 0 {
ids := make([]int, len(subscribedTemplateIds))
copy(ids, subscribedTemplateIds)
v["subscribedTemplateIds"] = &ids
} else {
v["subscribedTemplateIds"] = (*[]int)(nil)
}
err := client.Mutate(&m, v, WithName("RunnerRegister"))
return &m.Payload.Runner, HandleErrors(err, m.Payload.Errors)
}
Expand Down
20 changes: 18 additions & 2 deletions job_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
func TestRunnerRegister(t *testing.T) {
// Arrange
testRequest := autopilot.NewTestRequest(
`mutation RunnerRegister{runnerRegister{runner{id,status},errors{message,path}}}`,
`{}`,
`mutation RunnerRegister($subscribedTemplateIds:[Int!]){runnerRegister(subscribedTemplateIds: $subscribedTemplateIds){runner{id,status},errors{message,path}}}`,
`{"subscribedTemplateIds": null}`,
`{"data": {"runnerRegister": { "runner": { "id": "1234", "status": "registered" }, "errors": [] }}}`,
)

Expand All @@ -23,6 +23,22 @@ func TestRunnerRegister(t *testing.T) {
autopilot.Equals(t, ol.ID("1234"), result.Id)
}

func TestRunnerRegisterWithTemplateIds(t *testing.T) {
// Arrange
testRequest := autopilot.NewTestRequest(
`mutation RunnerRegister($subscribedTemplateIds:[Int!]){runnerRegister(subscribedTemplateIds: $subscribedTemplateIds){runner{id,status},errors{message,path}}}`,
`{"subscribedTemplateIds": [1, 2, 3]}`,
`{"data": {"runnerRegister": { "runner": { "id": "1234", "status": "registered" }, "errors": [] }}}`,
)

client := BestTestClient(t, "job/register_with_templates", testRequest)
// Act
result, err := client.RunnerRegister(1, 2, 3)
// Assert
autopilot.Ok(t, err)
autopilot.Equals(t, ol.ID("1234"), result.Id)
}

func TestRunnerGetScale(t *testing.T) {
// Arrange
testRequest := autopilot.NewTestRequest(
Expand Down