Skip to content

refactor: remove extra comment from migration #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prafull-opensignlabs merged 2 commits into from
Apr 27, 2025
Merged

refactor: remove extra comment from migration #1705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3b79cb
Merge pull request #547 from OpenSignLabs/staging
prafull-opensignlabs Apr 27, 2025
740ccca
Merge pull request #1704 from OpenSignLabs/updates-14689408163
prafull-opensignlabs Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions apps/OpenSignServer/databases/migrations/20250424104819-change_permission.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ async function ensureSchema(Parse, className, setupFn) {
try {
// If class exists, update it
await schema.update();
console.log(`✅ Updated schema for ${className}`);
} catch (e) {
// Otherwise, create it
await schema.save();
console.log(`✅ Created schema for ${className}`);
}
}

Expand All @@ -24,10 +22,7 @@ async function patchSchema(Parse, className, setupFn) {
setupFn(schema);
try {
await schema.update();
console.log(`🔄 Reverted schema for ${className}`);
} catch (e) {
console.warn(`⚠️ Skipping ${className} in down (not found)`);
}
} catch (e) {}
}

exports.up = async Parse => {
Expand Down