Fix thinking block dots layout race condition#423
Conversation
📝 WalkthroughWalkthroughUI adjustments to the ThinkingBlock dot layout (switching containers to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Deploying maple with
|
| Latest commit: |
56a6791
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27644d11.maple-ca8.pages.dev |
| Branch Preview URL: | https://claude-issue-422-20260213-05.maple-ca8.pages.dev |
Greptile OverviewGreptile SummaryThis PR addresses a layout race condition in the ThinkingBlock component and pins an Android CI dependency for stability. The main change converts the thinking indicator from Key changes:
The layout fix is straightforward and correctly addresses the alignment issue by ensuring the thinking indicator and its animated dots participate in inline flow rather than creating a block-level flex container. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 56a6791 |
|
@TestFlight build |
|
🚀 TestFlight deployment triggered! Check the Actions tab for progress. |
|
❌ TestFlight deployment failed. Check the workflow logs for details. |
Changed flex layout to inline-flex with inline-block dots to prevent vertical misalignment issues that were appearing on desktop during streaming. The dots now properly align with the text baseline. Fixes #422 Co-authored-by: Anthony <AnthonyRonning@users.noreply.github.com>
81ea56d to
b99744c
Compare
|
@TestFlight build |
|
🚀 TestFlight deployment triggered! Check the Actions tab for progress. |
|
✅ TestFlight deployment completed successfully! |
The v1.6.0 release of nttld/setup-ndk (today) broke NDK extraction, leaving clang binaries missing. Pin to v1.5.0 as a workaround. See: nttld/setup-ndk#576 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
25c786e to
56a6791
Compare
Fixes #422
Changed flex layout to inline-flex with inline-block dots to prevent vertical misalignment issues that were appearing on desktop during streaming. The dots now properly align with the text baseline.
Changes
Generated with Claude Code
Summary by CodeRabbit
Style
Chores