hid: asus-ally-hid: add the ROG ally driver#11
Open
NeroReflex wants to merge 17 commits intoOpenGamingCollective:ogc-6.19.yfrom
Open
hid: asus-ally-hid: add the ROG ally driver#11NeroReflex wants to merge 17 commits intoOpenGamingCollective:ogc-6.19.yfrom
NeroReflex wants to merge 17 commits intoOpenGamingCollective:ogc-6.19.yfrom
Conversation
pastaq
requested changes
Feb 19, 2026
Member
pastaq
left a comment
There was a problem hiding this comment.
Please follow the guidance listed here for PR's to the kernel as it makes updating the base version much easier.
https://github.com/OpenGamingCollective/organization-governance/blob/main/kernel/kernel_patching.md
Specifically, the patches should be labeled as [FOR-UPSTREAM] since this version is not yet on the ML.
Adds basic support for the joystick RGB LED rings as a multicolour LED device with 4 LEDs. As this uses the software-mode for setting the LED colours it also sets the MCU-mode for LED's to static + the first RGB colour on suspend/reboot/shutdown. This is done to prevent user confusion if the LED's were to not match what was set, and to maintain consistency. Signed-off-by: Luke D. Jones <luke@ljones.dev>
Export the validate_mcu_fw_version() symbol in namespace and use in hid-asus-ally if the driver is enabled. Signed-off-by: Luke Jones <luke@ljones.dev>
Enable use of the new gamepad device created by the MCU. - Triggers - Buttons - Sticks - Vibration Signed-off-by: Luke D. Jones <luke@ljones.dev>
Add the basics of the gamepad configuration options. Makes the gamepad usable. Signed-off-by: Luke D. Jones <luke@ljones.dev>
Add the full set of button remapping abilities for plain remap and macro remap (hold one button, press another for macro mapped action). Signed-off-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Add the mcu_version sysfs attribute so that userspace has a way to check the MCU FW version. Signed-off-by: Luke Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
The hid report for the QAM button changed on the ASUS ROG Xbox Ally X, so add the new mapping for the short press event. Otherwise, all we get is a long press event on "Asus Keyboard". neptune: We're carrying this as [NOT-FOR-UPSTREAM] because the last version of hid-asus-ally on lkml was in August of 2024, and we have some divergence from the last submission upstream. This should be included upstream when there is a new submission for hid-asus-ally. Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com> Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
With the current ROG Ally patchset, the MCU will send spurious events when the ROG Ally is in s2idle while plugged in, which can cause the system to wake unexpectedly. There's really no reason the N-Key needs wakeup enabled, so just disable the capability for now. This can be dropped when the issue is root caused and fixed within the standard ROG Ally patchset. Closes: ValveSoftware/SteamOS#2119 Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
3db2f53 to
36b9a80
Compare
Author
|
git just strips the tag. No idea how to retain it |
Member
Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patchset add the ROG ally driver as in use on chachyos already.
This patch series is in development and is added to avoid regressing
ROG ally and ROG ally x devices, allowing InputPlumber to control the
device.
This driver is in development.
Link: https://lore.kernel.org/all/20240806081212.56860-1-luke@ljones.dev/