Add default port option for Factorio game server#356
Open
karlh5926 wants to merge 2 commits intoOpenFactorioServerManager:developfrom
Open
Add default port option for Factorio game server#356karlh5926 wants to merge 2 commits intoOpenFactorioServerManager:developfrom
karlh5926 wants to merge 2 commits intoOpenFactorioServerManager:developfrom
Conversation
The default port can be specified via command line flag --game-port Or, via the the config json file with key "factorio_port". The default port will show up on the control page as the default value for game server. In cases where where we need a factorio server port different from the default. E.g. in my case, my admins can only use 34000 port since this is the only port that's forwarded. This feature eliminates the tedium & potential human error involved in having to maually edit the game port number everytime.
Add a conf.json option "factorio_port_lock". When set to true, force the game to run on the default "factorio_port" (--game-port on command line flag). This prevents confused admins when they run the game on a different port and can't get a connection. It also grays out the port field so it is not editable on the FSM Controls tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a default Factorio port option that can be specified via command line flag --game-port
Or, via the the config json file with key "factorio_port".
Add a conf.json option "factorio_port_lock". When set to true, force
the game to run on the default "factorio_port" (--game-port on command
line flag).
The default port will show up on the control page as the default
value for game server.
In cases where where we need a factorio server port different
from the default.
E.g. in my case, my admins can only use 34000 port since this is
the only port that's forwarded. This feature eliminates the
tedium & potential human error involved in having to maually
edit the game port number everytime.