Fixes issues with fetching some app's assets#136
Open
darrenwjlau wants to merge 1 commit intoOpenAsar:mainfrom
Open
Fixes issues with fetching some app's assets#136darrenwjlau wants to merge 1 commit intoOpenAsar:mainfrom
darrenwjlau wants to merge 1 commit intoOpenAsar:mainfrom
Conversation
CanadaHonk
requested changes
Jan 26, 2025
Contributor
CanadaHonk
left a comment
CanadaHonk
left a comment
There was a problem hiding this comment.
Sorry but I dislike this doing any networking or auth manually, it should use webpack modules.
Author
|
Yes I dislike that too
But yesterday there was a discord api failure for it so I coded up this
resilient way that it will always work
…On Sun, 26 Jan 2025, 8:33 am Oliver Medhurst, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Sorry but I dislike this doing any networking or auth manually, it should
use webpack modules.
—
Reply to this email directly, view it on GitHub
<#136 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO6YPGAHXXSICBVUTC7ZIE32MQUOLAVCNFSM6AAAAABVY4PFTSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZUGEYDSMBSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #135
It directly contacts discord to pull asset using the way from discord dev portal and also add external assets the same way normal client does it