Tedefo 4806 tighter type checking#130
Merged
bertrand-lorentz merged 8 commits intodevelopfrom Feb 3, 2026
Merged
Conversation
…FO-4808) Refactored expression model with separate scalar/sequence hierarchies. Introduced EfxTypeLattice for type variant management and TypeChecker interface for SDK-specific type validation. Updated translators to handle new expression model. Improved error reporting with ConsistencyCheckException for internal consistency checks. Enhanced symbol resolver for attribute fields. Added test coverage for sequence literals and context variables.
…ter-type-checking
bertrand-lorentz
requested changes
Feb 3, 2026
Contributor
bertrand-lorentz
left a comment
bertrand-lorentz
left a comment
There was a problem hiding this comment.
Test coverage seems OK.
See my comment on a an incorrect or confusing code comment.
src/test/java/eu/europa/ted/efx/sdk2/EfxExpressionTranslatorV2Test.java
Outdated
Show resolved
Hide resolved
bertrand-lorentz
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements tighter type checking across the EFX toolkit and introduces EFX Rules to Schematron translation capabilities.
Type Checking Infrastructure:
EfxTypeLatticefor type variant managementTypeCheckerinterface for SDK-specific type validationConsistencyCheckExceptionfor better error diagnosticsEFX Rules Translation:
EfxRulesTranslatorwith comprehensive test coverageValidatorGenerator,SchematronGenerator)Supporting Improvements:
Impact:
Enables compile-time type safety by distinguishing scalars from sequences, preventing type mismatches in EFX expressions. Provides foundation for generating validation artifacts from EFX Rules definitions.